8384088: osThread _thread_id should be an int on all BSD's by snake66 · Pull Request #31070 · openjdk/jdk

snake66 · 2026-05-07T11:29:23Z

The initializer for the _thread_id member in hotspot/os/bsd/osThread_bsd.cpp is incorrect for BSD's other than macOS. It should be an integer on all BSD's.

This work is sponsored by The FreeBSD Foundation

I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

JDK-8384088: osThread _thread_id should be an int on all BSD's (Enhancement - P4)

Reviewers

Paul Hübner (@Arraying - Committer)
David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31070/head:pull/31070
$ git checkout pull/31070

Update a local copy of the PR:
$ git checkout pull/31070
$ git pull https://git.openjdk.org/jdk.git pull/31070/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31070

View PR using the GUI difftool:
$ git pr show -t 31070

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31070.diff

Using Webrev

Link to Webrev Comment

The initializer for the _thread_id member in hotspot/os/bsd/osThread_bsd.cpp is incorrect for BSD's other than macOS. It should be an integer on all BSD's. This work is sponsored by The FreeBSD Foundation

bridgekeeper · 2026-05-07T11:30:59Z

👋 Welcome back haraldei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-05-07T11:31:08Z

@snake66 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8384088: osThread _thread_id should be an int on all BSD's

Reviewed-by: phubner, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 98 new commits pushed to the master branch:

3a0137a: 8360654: AArch64: Remove redundant dmb from C1 compareAndSet
25893e8: 8381413: G1: Verification accesses G1CollectorState checking whether in concurrent start gc after it has been reset for this pause
cf3e0cd: 8373289: Test tools/javac/patterns/Exhaustiveness.java timed out then passed
... and 95 more: https://git.openjdk.org/jdk/compare/c5b9e4db80ef41074ba51561b0cf24e8e804a98c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@Arraying, @dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2026-05-07T11:31:58Z

@snake66 The following label will be automatically applied to this pull request:

hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk · 2026-05-07T11:32:02Z

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-runtime. This can be overridden with the /reviewers command.

mlbridge · 2026-05-07T11:36:13Z

Webrevs

Arraying

IIUC, pid_t is actually __pid_t which is an __int32_t on FreeBSD. I checked OpenBSD and NetBSD as well (these are the ones we have macros for) and it's the same there. Seems like a reasonable change to me, thank you!

Arraying · 2026-05-08T14:58:47Z

Please bump.

This work is sponsored by The FreeBSD Foundation

dholmes-ora · 2026-05-12T06:22:29Z

 #include "runtime/mutex.hpp"
 #include "runtime/osThread.hpp"

-#include <signal.h>


Why did you remove this?

I did not see it being used by the code.

Line 40: sigemptyset(&_caller_sigmask);

Man! How could I miss that!
I'll put it back in :)

This work is sponsored by The FreeBSD Foundation

dholmes-ora

LGTM. Thanks

Arraying

Sorry, was on vacation. LGTM.

snake66 · 2026-05-18T12:53:46Z

Sorry, was on vacation. LGTM.

No worries, vacation is important! :) Thanks for the reviews @Arraying and @dholmes-ora!

snake66 · 2026-05-18T12:53:54Z

/integrate

openjdk · 2026-05-18T12:54:40Z

@snake66
Your change (at version d0d84a3) is now ready to be sponsored by a Committer.

Arraying · 2026-05-18T13:13:25Z

/sponsor

openjdk · 2026-05-18T13:16:37Z

Going to push as commit e9bc05c.
Since your change was applied there have been 99 commits pushed to the master branch:

407acbe: 8382888: [asan] ASAN crashes with high heap base addresses during startup
3a0137a: 8360654: AArch64: Remove redundant dmb from C1 compareAndSet
25893e8: 8381413: G1: Verification accesses G1CollectorState checking whether in concurrent start gc after it has been reset for this pause
... and 96 more: https://git.openjdk.org/jdk/compare/c5b9e4db80ef41074ba51561b0cf24e8e804a98c...master

Your commit was automatically rebased without conflicts.

openjdk · 2026-05-18T13:16:52Z

@Arraying @snake66 Pushed as commit e9bc05c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8384088: osThread _thread_id should be an int on all BSD's

168a1a1

The initializer for the _thread_id member in hotspot/os/bsd/osThread_bsd.cpp is incorrect for BSD's other than macOS. It should be an integer on all BSD's. This work is sponsored by The FreeBSD Foundation

openjdk Bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 7, 2026

openjdk Bot added the rfr Pull request is ready for review label May 7, 2026

Arraying reviewed May 8, 2026

View reviewed changes

Comment thread src/hotspot/os/bsd/osThread_bsd.cpp Outdated

Copy link
Copy Markdown

Member

Arraying May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump.

Update copyright year

226aa1a

This work is sponsored by The FreeBSD Foundation

dholmes-ora reviewed May 12, 2026

View reviewed changes

Putting signal.h back in where it should be

d0d84a3

This work is sponsored by The FreeBSD Foundation

dholmes-ora approved these changes May 13, 2026

View reviewed changes

snake66 requested a review from Arraying May 14, 2026 07:19

Arraying approved these changes May 18, 2026

View reviewed changes

openjdk Bot added the ready Pull request is ready to be integrated label May 18, 2026

openjdk Bot added the sponsor Pull request is ready to be sponsored label May 18, 2026

openjdk Bot added the integrated Pull request has been integrated label May 18, 2026

openjdk Bot closed this May 18, 2026

openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 18, 2026

Conversation

snake66 commented May 7, 2026 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper Bot commented May 7, 2026

Uh oh!

openjdk Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk Bot commented May 7, 2026

Uh oh!

mlbridge Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Arraying left a comment

Choose a reason for hiding this comment

Uh oh!

Arraying May 8, 2026

Choose a reason for hiding this comment

Uh oh!

dholmes-ora May 12, 2026

Choose a reason for hiding this comment

Uh oh!

snake66 May 12, 2026

Choose a reason for hiding this comment

Uh oh!

dholmes-ora May 12, 2026

Choose a reason for hiding this comment

Uh oh!

snake66 May 12, 2026

Choose a reason for hiding this comment

Uh oh!

dholmes-ora left a comment

Choose a reason for hiding this comment

Uh oh!

Arraying left a comment

Choose a reason for hiding this comment

Uh oh!

snake66 commented May 18, 2026

Uh oh!

snake66 commented May 18, 2026

Uh oh!

openjdk Bot commented May 18, 2026

Uh oh!

Arraying commented May 18, 2026

Uh oh!

openjdk Bot commented May 18, 2026

Uh oh!

openjdk Bot commented May 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

snake66 commented May 7, 2026 •

edited by openjdk Bot

Loading

openjdk Bot commented May 7, 2026 •

edited

Loading

openjdk Bot commented May 7, 2026 •

edited

Loading

mlbridge Bot commented May 7, 2026 •

edited

Loading